turn recorder into a node #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
requested review from
emersonknapp and
david-prody
and removed request for
a team
|
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Karsten1987
force-pushed
the
kk/recorder_node
branch
from
71e0913
to
faef74e
Compare
|
Kettenhoax
pushed a commit
to Kettenhoax/rosbag2
that referenced
this pull request
Apr 9, 2021
* turn recorder into a node Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * remove unused function Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
50 tasks
|
Related to #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step closer to #716.
Turn the recorder into a node instead of accepting one.