Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public recorder and player #739

Merged
merged 1 commit into from
Apr 20, 2021
Merged

public recorder and player #739

merged 1 commit into from
Apr 20, 2021

Conversation

Karsten1987
Copy link
Collaborator

one step closer to #716

making recorder and player API public.

@Karsten1987
public recorder and player
cf59ce3 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987 Karsten1987 requested a review from a team as a code owner April 19, 2021 23:13
@Karsten1987 Karsten1987 requested review from emersonknapp and zmichaels11 and removed request for a team April 19, 2021 23:13
@Karsten1987
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp
Copy link
Collaborator

I assume next step is to break it out of impl namespace and git rm rosbag2_transport/rosbag2_transport.hpp - and move the test fixtures over?

@Karsten1987 Karsten1987 mentioned this pull request Apr 20, 2021
Merged
@Karsten1987
Copy link
Collaborator Author

I assume next step is to break it out of impl namespace and git rm rosbag2_transport/rosbag2_transport.hpp - and move the test fixtures over?

I plan on having two PRs in between before I pull the trigger. #740 is using the public player in the API, yet maintains the same functionality in rosbag2_transport::Player. I'll do the same with the recorder API and then finally remove the rosbag2_transport and simply replace rosbag2_transport::impl::Player with rosbag2_transport::Player in the tests.

@emersonknapp emersonknapp merged commit 0eb452a into master Apr 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the kk/public_recorder_player branch April 20, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@zmichaels11 zmichaels11 Awaiting requested review from zmichaels11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @emersonknapp