Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Seek service #874

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add a Seek service #874

merged 1 commit into from
Oct 28, 2021

Conversation

emersonknapp
Copy link
Collaborator

Add to Player to be able to call Seek from a remote controller

@emersonknapp emersonknapp mentioned this pull request Sep 28, 2021
Closed
50 tasks
@emersonknapp emersonknapp force-pushed the emersonknapp/jump-service branch 2 times, most recently from 9339b15 to 67efc43 Compare October 27, 2021 23:26
@emersonknapp
Add a Seek service
f2672f8 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp marked this pull request as ready for review October 27, 2021 23:35
@emersonknapp emersonknapp requested a review from a team as a code owner October 27, 2021 23:35
@emersonknapp emersonknapp requested review from Karsten1987 and jhdcs and removed request for a team October 27, 2021 23:35
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/0c6863e97cda75195e84c2d7b47f9c4e/raw/2360ca15d133d910c9c67a5ca2f30abf2e706c8d/ros2.repos
BUILD args: --packages-up-to rosbag2_transport rosbag2_tests rosbag2
TEST args: --packages-select rosbag2_transport rosbag2_tests rosbag2
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/9252

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 3581a16 into master Oct 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/jump-service branch October 28, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihui815 lihui815 lihui815 approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987 Karsten1987 is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonknapp @lihui815