Add simple keyboard control for playback rate #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
Karsten1987 and
jhdcs
and removed request for
a team
lihui815
reviewed
Oct 27, 2021
lihui815
approved these changes
Oct 27, 2021
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Gist: https://gist.githubusercontent.com/emersonknapp/9c69653c783a4be4489d75b410c02512/raw/bbfc4ef33db92050d3c8366917e493dc56105dad/ros2.repos
|
delete-merged-branch
bot
deleted the
emersonknapp/rate-keyboard-control
branch
| @@ -147,6 +155,9 @@ TEST_F(RosBag2PlayTestFixture, test_keyboard_controls) | |||
| keyboard_handler->simulate_key_press(play_options_.pause_resume_toggle_key); | |||
| EXPECT_THAT(player->is_paused(), true); | |||
|
|
|||
| keyboard_handler->simulate_key_press(play_options_.increase_rate_key); | |||
| keyboard_handler->simulate_key_press(play_options_.decrease_rate_key); | |||
There was a problem hiding this comment.
Sorry for posting in closed PR.
Just in case for future. It would be better to check rate va player->get_rate() before changing it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.