Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parentheses suggested by Clang on OSX to fix build warning #930

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Add parentheses suggested by Clang on OSX to fix build warning #930

merged 1 commit into from
Dec 3, 2021

Conversation

emersonknapp
Copy link
Collaborator

See #920 (comment) - #920 introduced a Clang build warning

Add parentheses suggested by Clang on OSX to fix build warning
0c962a9 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested a review from a team as a code owner December 3, 2021 18:06
@emersonknapp emersonknapp requested review from MichaelOrlov and hidmic and removed request for a team December 3, 2021 18:06
@emersonknapp emersonknapp mentioned this pull request Dec 3, 2021
Merged
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/79fcdf7a5147a15dd58507153d580208/raw/ffd663f6053f29b21fac9c3dbfdd897348bad529/ros2.repos
BUILD args: --packages-up-to rosbag2_transport
TEST args: --packages-select rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/9442

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Blast545
Blast545 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a quick look into this. LGTM after green CI.

@emersonknapp emersonknapp merged commit d40ee75 into master Dec 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/fix-osx-clang branch December 3, 2021 20:22
@Blast545 Blast545 mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonknapp @Blast545