[humble] Don't warn for unknown types if topics are not selected (backport #1466) #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Don't warn for unknown types if topics are not in the list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests to verify regression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move checks for single type and hidden topics to the bottom Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit bf4038d)
mergify
bot
requested review from
emersonknapp and
jhdcs
and removed request for
a team
MichaelOrlov
changed the title
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/95a594a1f0ba9c90fbd6584bacbeb96a/raw/b5393909bd43b25ed516b5851bde8bf8fc69a5b7/ros2.repos
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1466 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com