Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn for unknown types if topics are not selected #1466

Merged
merged 3 commits into from Sep 13, 2023
Merged

Don't warn for unknown types if topics are not selected #1466

merged 3 commits into from Sep 13, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented Sep 12, 2023 •
edited

Move the check for the unknown types to the bottom of the checks in the topic_filter

@MichaelOrlov
Don't warn for unknown types if topics are not in the list
fa84bbe 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This was referenced Sep 12, 2023
Closed
Closed
@MichaelOrlov MichaelOrlov marked this pull request as ready for review September 12, 2023 21:02
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner September 12, 2023 21:02
@MichaelOrlov MichaelOrlov requested review from gbiggs and hidmic and removed request for a team September 12, 2023 21:02
@MichaelOrlov
Add unit tests to verify regression
216d70e 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/dont_warn_for_unknown_types_if_not_in_list branch from 01e79d6 to 216d70e Compare September 12, 2023 21:25
@MichaelOrlov MichaelOrlov changed the title Don't warn for unknown types if topics are not in the list Don't warn for unknown types if topics are not selected Sep 12, 2023
@MichaelOrlov
Move checks for single type and hidden topics to the bottom
c00d210 
Rationale: To avoid irrelevant warning messages if topic name hasn't
been selected by topic list or regex.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
clalancette
clalancette approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/adcb2b4665fb508ad1eb5d0dfcbe33a2/raw/984aaa1ad42a47abc033e08b10fe00857e7085b0/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_tests
TEST args: --packages-above rosbag2_transport rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12658

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit bf4038d into rolling Sep 13, 2023
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the morlov/dont_warn_for_unknown_types_if_not_in_list branch September 13, 2023 23:13
@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport iron

@mergify
Copy link

mergify bot commented Sep 13, 2023 •
edited

backport iron

✅ Backports have been created

@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport humble

@mergify
Copy link

mergify bot commented Sep 13, 2023 •
edited

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@MichaelOrlov @mergify
Don't warn for unknown types if topics are not selected (#1466)
b2b6cf5 
* Don't warn for unknown types if topics are not in the list

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Add unit tests to verify regression

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Move checks for single type and hidden topics to the bottom

Rationale: To avoid irrelevant warning messages if topic name hasn't
been selected by topic list or regex.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit bf4038d)
@mergify mergify bot mentioned this pull request Sep 13, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 13, 2023
@MichaelOrlov @mergify
Don't warn for unknown types if topics are not selected (#1466)
192d9a4 
* Don't warn for unknown types if topics are not in the list

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Add unit tests to verify regression

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Move checks for single type and hidden topics to the bottom

Rationale: To avoid irrelevant warning messages if topic name hasn't
been selected by topic list or regex.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit bf4038d)
@mergify mergify bot mentioned this pull request Sep 13, 2023
Merged
MichaelOrlov added a commit that referenced this pull request Sep 14, 2023
@mergify @MichaelOrlov
Don't warn for unknown types if topics are not selected (#1466) (#1469)
f9b26c5 
* Don't warn for unknown types if topics are not in the list

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Add unit tests to verify regression

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Move checks for single type and hidden topics to the bottom

Rationale: To avoid irrelevant warning messages if topic name hasn't
been selected by topic list or regex.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit bf4038d)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov added a commit that referenced this pull request Sep 14, 2023
@mergify @MichaelOrlov
Don't warn for unknown types if topics are not selected (#1466) (#1468)
51a83f4 
* Don't warn for unknown types if topics are not in the list

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Add unit tests to verify regression

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Move checks for single type and hidden topics to the bottom

Rationale: To avoid irrelevant warning messages if topic name hasn't
been selected by topic list or regex.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit bf4038d)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-09-21/33733/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not warn for unknown types if they are not included in the topic list
4 participants
@MichaelOrlov @ros-discourse @clalancette @fujitatomoya