[jazzy] Bugfix for bag_split event callbacks called to early with file compression (backport #1643) #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…ssion (#1643) * Bugfix for bag_split event callbacks not called with file compression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Delete redundant "should_split_bagfile" in compression_writer - It is a non-virtual method and doesn't call from the base class. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Adjust "split_event_calls_callback" for testing multiple splits Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use temp folder for "SequentialWriterTest" fixture instead of "uri" Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add tests for split event callbacks when using file and msg compression - Added "split_event_calls_callback_with_msg_compression" and "split_event_calls_callback_with_file_compression" uit tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add debug info to the flaky "can_record_again_after_stop" test Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use `uint64_t` type for `fake_storage_size_` in tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 1877b53)
mergify
bot
requested review from
gbiggs and
hidmic
and removed request for
a team
MichaelOrlov
changed the title
MichaelOrlov
requested review from
MichaelOrlov
and removed request for
gbiggs and
hidmic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosbag2_cpp::Writer. i.e. callbacks calling when the bag file closes. However, the expected behavior is that callbacks are called when compression is finished and the original bag file is deleted.Update: Jun-06-2024 Added unit tests to cover changes.
This is an automatic backport of pull request #1643 done by Mergify.