Fix splitting tests on windows

[Karsten1987]

fixes #305

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

Look at that, a green Windows build :)

This is ready for review.

[brawner]

European extreme:

[Karsten1987]

that looks now like a different problem:

[ERROR] [1589185764.148699300] [rosbag2_storage]: Could not open 'C:\Users\ContainerAdministrator\AppData\Local\Temp\tmp_test_dir.a07544\record_end_to_end_test_with_zstd_file_compression_compresses_files\record_end_to_end_test_with_zstd_file_compression_compresses_files_0' with 'sqlite3'. Error: Failed to setup storage. Error: Error when processing SQL statement. SQLite error (5): database is locked

That looks like another timing issue where the database is locked or not released on time before the next test starts.

[brawner]

Doing a search for [ OK ] RecordFixture.record_end_to_end_test_with_zstd_file_compression_compresses_files shows the test passed 34 times before it failed. I don't think we'll see this come up in CI anymore.

[Karsten1987]

I've let it run 100 times wo/ any errors on my local Windows VM with the latest change. Regarding the SQL Locks, there was a PR from @sriramster in #189 which we never pursued any further. But I think it's orthogonal to the fix proposed here.

EDIT: I've just seen there is already an open ticket for that case where the database is locked: #240

[piraka9011]

Is the solution basically just cleaning up all directories at the end of each test run?

[Karsten1987]

no, the fix is to fill in the metadata correctly.