Revert "rosbag2_py reader and writer" #507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 038bae2.
|
What about disabling the package with an ignore file while we work to fix CI for the affected platforms? |
|
Closing in favor of adding |
|
I would not revert based on Clang since it's not a tier 1 platform, I'd instead just make sure to prioritize looking for a fix - though I see you closed this so I guess we're good to go 👍 |
That's true, but I think it is also causing problems on Windows Debug: https://ci.ros2.org/view/nightly/job/nightly_win_deb/1714/#showFailuresLink In any case, I like the idea to AMENT_IGNORE it for now, then deal with it next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #308 due to Nightly failures on Debug mode in Windows #504 and Linux with Clang #505
We have a solution for Linux with Clang that passes the compiler but the tests are failing.
Still need to look into Windows.