Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always preserve source permissions in vendor packages #645

Merged
merged 1 commit into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. Always preserve source permissions in vendor packages

    In vendor packages where we're installing an executable, we use
    USE_SOURCE_PERMISSIONS to make sure that the executable permissions on
    the binaries are maintained when the external project's staging
    directory is recursively installed to the final installation directory.
    
    In most of our vendor packages, we aren't using that flag where we don't
    expect an executable binary to be installed. However, for reasons I
    won't go into here, some systems use executable permissions on shared
    object libraries as well. The linker seems to handle this on our behalf,
    but we're losing the permissions during the recursive copy operation if
    we don't use this flag.
    
    Signed-off-by: Scott K Logan <logans@cottsay.net>
    cottsay committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    94e7486 View commit details
    Browse the repository at this point in the history