Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support adjacent string literals, use them for multi-line comments #410

Merged
merged 2 commits into from
Sep 11, 2019
Merged

support adjacent string literals, use them for multi-line comments #410

merged 2 commits into from
Sep 11, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Sep 10, 2019 •
edited
Loading

Replaces #406.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added bug Something isn't working enhancement New feature or request in review Waiting for review (Kanban column) labels Sep 10, 2019
@dirk-thomas dirk-thomas self-assigned this Sep 10, 2019
@dirk-thomas
support adjacent string literals
3f41534 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
use adjacent strings for multiline comments
5062f40 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/adjacent-string-literal_multiline-verbatim branch from b4392b1 to 5062f40 Compare September 10, 2019 16:29
This was referenced Sep 10, 2019
Closed
Merged
jacobperron
jacobperron approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI)

@dirk-thomas dirk-thomas merged commit 07a2ab5 into master Sep 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/adjacent-string-literal_multiline-verbatim branch September 11, 2019 04:29
@TSC21 TSC21 mentioned this pull request Sep 11, 2019
Closed
@TSC21 TSC21 mentioned this pull request Oct 14, 2019
Closed
jacobperron referenced this pull request Oct 14, 2019
@mjcarroll
0.8.0
2e7f775 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@TSC21
Copy link

TSC21 commented Oct 14, 2019

@dirk-thomas, @jacobperron is it possible to backport this feature to Dashing? Thank you!

jacobperron pushed a commit that referenced this pull request Oct 14, 2019
@dirk-thomas @jacobperron
support adjacent string literals, use them for multi-line comments (#410
e589f4a 
)

* support adjacent string literals

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use adjacent strings for multiline comments

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron mentioned this pull request Oct 14, 2019
Merged
jacobperron pushed a commit that referenced this pull request Oct 15, 2019
@dirk-thomas @jacobperron
support adjacent string literals, use them for multi-line comments (#410
f12f116 
)

* support adjacent string literals

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use adjacent strings for multiline comments

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@jacobperron jacobperron added this to Needs Release in Dashing Patch Release 4 Oct 15, 2019
@nuclearsandwich nuclearsandwich moved this from Needs Release to Needs Backport in Dashing Patch Release 4 Oct 15, 2019
@dirk-thomas
Copy link
Member Author

@nuclearsandwich This has already been backported in #419 but it needs a new release.

@dirk-thomas dirk-thomas removed this from Needs Backport in Dashing Patch Release 4 Oct 16, 2019
@nuclearsandwich
Copy link
Member

@nuclearsandwich This has already been backported in #419 but it needs a new release.

Thanks, the backport PR wasn't on the board so I couldn't track it. The backport window has closed so this will need to wait for the next sync.

@dirk-thomas
Copy link
Member Author

The backport window has closed so this will need to wait for the next sync.

This isn't ok. This should go into the current sync - the same for the other four repos which are listed in the "needs release" and " need backport" column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dirk-thomas @TSC21 @nuclearsandwich @jacobperron