Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating tests for rosidl_runtime_c, rosidl_typesupport_interface #484

Merged
merged 4 commits into from
May 12, 2020
Merged

Creating tests for rosidl_runtime_c, rosidl_typesupport_interface #484

merged 4 commits into from
May 12, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented May 9, 2020

No description provided.

@brawner brawner self-assigned this May 9, 2020
ahcorde
ahcorde requested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are two tests commented

rosidl_runtime_c/test/test_string_functions.cpp Outdated Show resolved Hide resolved
rosidl_runtime_c/test/test_u16string_functions.cpp Outdated Show resolved Hide resolved
@brawner
Copy link
Contributor Author

brawner commented May 11, 2020

Thanks for the review. This was close to being finished, but didn't quite get to all of it before the weekend. So for now it was marked as a draft.

@brawner
Copy link
Contributor Author

brawner commented May 11, 2020 •
edited
Loading

Tests look good now.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Coverage Build Status

@brawner brawner marked this pull request as ready for review May 11, 2020 21:34
@brawner
Creating tests for rosidl_runtime_c, rosidl_typesupport_interface
32612bc 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented May 11, 2020

Fixing Windows issue and boosting coverage.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
Up coverage
a617fd1 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented May 11, 2020 •
edited
Loading

Adding c++14 for tests only.

  • macOS Build Status

@brawner brawner force-pushed the brawner/add_tests branch 2 times, most recently from 6aac413 to dc386c2 Compare May 11, 2020 23:04
@brawner
c++14
7f5480e 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented May 11, 2020

Tests are finally green.

cottsay
cottsay approved these changes May 12, 2020
View reviewed changes
rosidl_runtime_c/CMakeLists.txt Outdated Show resolved Hide resolved
rosidl_runtime_c/test/test_string_functions.cpp Show resolved Hide resolved
@brawner
Copy link
Contributor Author

brawner commented May 12, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
PR Fixup
d2d7153 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner merged commit d22745d into master May 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/add_tests branch May 12, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

@cottsay cottsay cottsay approved these changes

Assignees

@brawner brawner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brawner @cottsay @ahcorde