Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QD to reflect QL 2 statuses. #499

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Jun 5, 2020

Updates rosidl_runtime_cpp and rosidl_typesupport_interface.

Signed-off-by: Stephen Brawner brawner@gmail.com

Updates rosidl_runtime_cpp and rosidl_typesupport_interface.

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested review from ahcorde and Blast545 June 5, 2020 02:15
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage link is not working

rosidl_runtime_cpp/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once pending comments are addressed

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner merged commit 860740d into master Jun 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/quality-declaration-ql2 branch June 5, 2020 22:12
@chapulina chapulina mentioned this pull request Jun 18, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants