Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the output size unconditionally when copying sequences #669

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Mar 9, 2022

Fixes the bug mentioned in #667 (comment)

Signed-off-by: Nikolai Morin nnmmgit@gmail.com

Signed-off-by: Nikolai Morin <nnmmgit@gmail.com>
@nnmm
Copy link
Contributor Author

nnmm commented Mar 9, 2022

@hidmic Could you review?

@hidmic hidmic self-requested a review March 17, 2022 14:46
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI, though a regression test would be nice

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor

hidmic commented Mar 17, 2022

@ros-pull-request-builder retest this please

@hidmic
Copy link
Contributor

hidmic commented Mar 18, 2022

Alright, Rpr jobs are broken, going in!

@hidmic hidmic merged commit 90c5d1c into ros2:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants