Add option to rosidl_generate_interfaces to skip dependency export. #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dependency is declared in rosidl_generate_interfaces(), ament_export_dependencies() for that dependency is automatically called. That is the correct default behavior, but it isn't always the behavior that is wanted. In particular, if a package has messages that are only used for tests, we don't want to export those dependencies downstream. Add an option to skip dependency export for rosidl_generate_interfaces. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI for this is over in ros-tooling/libstatistics_collector#145 (comment) |
sloretz
requested changes
Sep 30, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
That's fair. Made that change in 9013e83; please take another look. |
sloretz
approved these changes
Oct 4, 2022
|
Latest CI for this is over in ros-tooling/libstatistics_collector#145 (comment) (and it is green). So going ahead and merging this; thanks for the review! |
clalancette
deleted the
clalancette/add-option-to-skip-dependency-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dependency is declared in rosidl_generate_interfaces(), ament_export_dependencies() for that dependency is automatically called. That is the correct default behavior, but it isn't always the behavior that is wanted. In particular, if a package has messages that are only used for tests, we don't want to export those dependencies downstream. Add an option to skip dependency export for rosidl_generate_interfaces.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This came out of ros-tooling/libstatistics_collector#54 , and
libstatistics_collectorwill be the first user of it.