Make sure to add the event message to typesupport introspection cpp. #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the RMWs that use introspection, rather than statically generated code. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
|
CI:
|
methylDragon
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Rpr job is failing for some reason, I'm gonna trigger a rerun. Other than that, LGTM on green CI
Edit: Ah, the merge of ros2/rcl_interfaces#143 requires that service_msgs be added to rosdistro, we need to wait for a release
The Rpr jobs are going to fail at the moment since we need to do a release of this package (and a few others). We are blocked on that for the moment by some other regressions, so we should just use CI for now. Hopefully this will get unblocked later in the week. |
mjcarroll
approved these changes
Feb 9, 2023
clalancette
deleted the
clalancette/add-event-message-to-introspection-srv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the RMWs that use introspection, rather than statically generated code.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Along with ros2/rosidl_typesupport#132, this should fix the error mentioned in ros2/ros2#1285 (comment)