-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Interface Reflection: rosidl #728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
requested review from
adityapande-1995,
quarkytale and
sloretz
as code owners
March 16, 2023 16:56
This was referenced Mar 16, 2023
methylDragon
force-pushed
the
runtime_interface_reflection
branch
3 times, most recently
from
March 18, 2023 09:06
9115cea
to
74d35b0
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
2 times, most recently
from
March 28, 2023 22:30
4155c36
to
a1cc3d8
Compare
methylDragon
changed the base branch from
rolling
to
emersonknapp/type-description-runtime
March 28, 2023 22:30
methylDragon
force-pushed
the
runtime_interface_reflection
branch
7 times, most recently
from
April 4, 2023 20:05
61a04cd
to
27d6e78
Compare
methylDragon
changed the base branch from
emersonknapp/type-description-runtime
to
emersonknapp/type-description-struct
April 5, 2023 23:35
methylDragon
force-pushed
the
runtime_interface_reflection
branch
from
April 5, 2023 23:36
27d6e78
to
3fc6394
Compare
wjwwood
requested changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review with a few requested changes, but mostly non-blocking nitpicks.
We're still trying to nail down the double-free issues in some of the tests.
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection
branch
2 times, most recently
from
April 7, 2023 02:08
f759287
to
a448392
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection
branch
from
April 7, 2023 02:13
a448392
to
b759f94
Compare
I'm not too sure why DCO is kicking up a fuss |
methylDragon
changed the base branch from
emersonknapp/type-description-struct
to
rolling
April 7, 2023 05:33
wjwwood
reviewed
Apr 7, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends (and is based on): #727
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
emersonknapp/type-descripton-runtime
branch it builds ontop of to help with reviewing. But when #727 gets merged, this should then retargetrolling
Description
This PR adds utilities for manipulating the
rosidl_runtime_c__type_description
structs defined in #727It was migrated (and further modified from): ros2/rcl_interfaces#155
Functionalities:
Asan runs green too!
There are some less important tests waiting to be written (printing), and some tests that are already implicitly covered by other tests (but are not explicit yet.)
TODO
Open Questions