Commits on Jun 8, 2023

1. Fix deprecation warnings for message constants (#750) …

   Fixes #743
   
   This patch fixes two issues:
   1. Code generation for `rosidl_typesupport_introspection_cpp` was overriding user-provided compile definitons, hiding the `-Wdeprecated` warnings in generated code, that users did see in `rosidl_typesupport_fastrtps_cpp`, which was not overriding those compile flags. This inconsistent result confused the issue of why we were seeing deprecation warnings in some portion of the build but not others
   1. `#ifdef`s out a variable definition for message constant members that is now deprecated in C++17. In C++14 it was still necessary to define a `static constexpr` member variable outside the class, but as of C++17 those `static constexpr` vars are now automatically inlined so the declaration and definiton are the same line, making the external definition redundant.
   
   Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
   (cherry picked from commit 1228f54)

   

   emersonknapp authored and mergify[bot] committed Jun 8, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 66e93dc
   • Browse repository at this point

   Copy the full SHA

   66e93dc View commit details

   Browse the repository at this point in the history