Fix deprecation warnings for message constants #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
Fixes ros2#743 This patch fixes two issues: 1. Code generation for `rosidl_typesupport_introspection_cpp` was overriding user-provided compile definitons, hiding the `-Wdeprecated` warnings in generated code, that users did see in `rosidl_typesupport_fastrtps_cpp`, which was not overriding those compile flags. This inconsistent result confused the issue of why we were seeing deprecation warnings in some portion of the build but not others 1. `#ifdef`s out a variable definition for message constant members that is now deprecated in C++17. In C++14 it was still necessary to define a `static constexpr` member variable outside the class, but as of C++17 those `static constexpr` vars are now automatically inlined so the declaration and definiton are the same line, making the external definition redundant. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/rosidl-deprecation-warnings
branch
from
d5f3921
to
90f4b61
Compare
clalancette
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Thanks for tracking this down! This looks good to me with green CI. I'll also suggest that once we merge this and ros2/rosidl_typesupport_fastrtps#102 , we do a more-or-less immediate release into Rolling just to make sure there isn't any fallout from them. I can help with that.
|
Pulls: #750, ros2/rosidl_typesupport#145, ros2/rosidl_typesupport_fastrtps#102
|
|
Rerunning aarch64 |
|
OK - now it's just the |
|
@Mergifyio backport iron humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Fixes #743 This patch fixes two issues: 1. Code generation for `rosidl_typesupport_introspection_cpp` was overriding user-provided compile definitons, hiding the `-Wdeprecated` warnings in generated code, that users did see in `rosidl_typesupport_fastrtps_cpp`, which was not overriding those compile flags. This inconsistent result confused the issue of why we were seeing deprecation warnings in some portion of the build but not others 1. `#ifdef`s out a variable definition for message constant members that is now deprecated in C++17. In C++14 it was still necessary to define a `static constexpr` member variable outside the class, but as of C++17 those `static constexpr` vars are now automatically inlined so the declaration and definiton are the same line, making the external definition redundant. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 1228f54)
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Fixes #743 This patch fixes two issues: 1. Code generation for `rosidl_typesupport_introspection_cpp` was overriding user-provided compile definitons, hiding the `-Wdeprecated` warnings in generated code, that users did see in `rosidl_typesupport_fastrtps_cpp`, which was not overriding those compile flags. This inconsistent result confused the issue of why we were seeing deprecation warnings in some portion of the build but not others 1. `#ifdef`s out a variable definition for message constant members that is now deprecated in C++17. In C++14 it was still necessary to define a `static constexpr` member variable outside the class, but as of C++17 those `static constexpr` vars are now automatically inlined so the declaration and definiton are the same line, making the external definition redundant. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 1228f54)
This was referenced Jun 8, 2023
emersonknapp
added a commit
that referenced
this pull request
Jun 14, 2023
Fix deprecation warnings for message constants (backport #750)
emersonknapp
added a commit
that referenced
this pull request
Jun 14, 2023
Fix deprecation warnings for message constants (backport #750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
This patch fixes two issues:
rosidl_typesupport_introspection_cppwas overriding user-provided compile definitons, hiding the-Wdeprecatedwarnings in generated code, that users did see inrosidl_typesupport_fastrtps_cpp, which was not overriding those compile flags. This inconsistent result confused the issue of why we were seeing deprecation warnings in some portion of the build but not others#ifdefs out a variable definition for message constant members that is now deprecated in C++17. In C++14 it was still necessary to define astatic constexprmember variable outside the class, but as of C++17 thosestatic constexprvars are now automatically inlined so the declaration and definiton are the same line, making the external definition redundant.