Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport array optimization to Galactic and Foxy #135

Closed
sloretz opened this issue Jun 11, 2021 · 9 comments
Closed

Backport array optimization to Galactic and Foxy #135

sloretz opened this issue Jun 11, 2021 · 9 comments

Comments

@sloretz
Copy link
Contributor

sloretz commented Jun 11, 2021

This is an issue to backport #129 to Galactic and Foxy. I think it would be a good idea to have it sit in Rolling a little bit to make sure it works since it changes something so low level.

@clalancette clalancette added this to Proposed in Foxy Patch Release 5 via automation Jul 1, 2021
@clalancette clalancette added this to Proposed in Galactic Patch Release 1 via automation Jul 1, 2021
@jacobperron jacobperron removed this from Proposed in Foxy Patch Release 5 Sep 1, 2021
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 6 via automation Sep 1, 2021
@cottsay cottsay removed this from Proposed in Galactic Patch Release 1 Sep 21, 2021
@cottsay cottsay added this to Proposed in Galactic Patch Release 2 Sep 21, 2021
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 6 Sep 29, 2021
@pulkitgoyal1506
Copy link

@sloretz Can we merge this patch on foxy now?
I am facing this issue on ros2::foxy, it would be great if this can be merged.

@sloretz
Copy link
Contributor Author

sloretz commented Oct 7, 2021

Seems like it has worked fine in Rolling. I'll backport to Galactic first out of caution since it's a very low level change.

#145

@jacobperron jacobperron added this to Proposed in Foxy Patch Release 7 via automation Oct 7, 2021
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 6 Oct 7, 2021
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 7 Oct 7, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Oct 9, 2021

Released to Galactic in 0.11.1 ros/rosdistro#30955

@hidmic
Copy link
Contributor

hidmic commented Dec 23, 2021

@sloretz have we backported this to Foxy already?

@sloretz
Copy link
Contributor Author

sloretz commented Dec 23, 2021

Yeah it's been backported. It might need a foxy release

@jacobperron jacobperron moved this from Needs backport to Needs release in Foxy Patch Release 7 Jan 31, 2022
@jacobperron jacobperron removed this from Needs release in Foxy Patch Release 7 Feb 7, 2022
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 8 via automation Feb 7, 2022
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 8 Feb 7, 2022
@jacobperron
Copy link
Member

jacobperron commented Jul 22, 2022

This has also been released into Foxy.

@travipross
Copy link

travipross commented Aug 24, 2022

This has also been released into Foxy.

@jacobperron Did you mean this as in, fetching the latest container from Dockerhub for ros2:foxy should include this fix?

I see this issue is listed as "Needs release" in the Foxy Release Patch 8 project, so I wasn't sure whether to expect this to exist in the official Docker image.

@jacobperron jacobperron moved this from Needs release to Done in Foxy Patch Release 8 Sep 6, 2022
@jacobperron
Copy link
Member

@travipross The patch was backported to Foxy in #146 and released in 0.9.5. It looks like 0.9.5 has also been sync'd to the main release repository: http://repo.ros2.org/status_page/ros_foxy_default.html?q=rosidl_python
So, the binary package should be available in Ubuntu. I'm not involved in maintaining the Docker image for Foxy, so I'm not sure what is required for updating it.

@jacobperron
Copy link
Member

And, the Foxy Patch release board is lagging behind a bit since I have to update it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants