Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change decode mode into replace. #176

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Change decode mode into replace. #176

merged 1 commit into from
Aug 9, 2022

Conversation

fujitatomoya
Copy link
Contributor

address ros2/rclpy#881

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

@fujitatomoya
Change decode mode into replace.
aa03aef 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Contributor Author

@iuhilnehc-ynos could you do review when you have time?

iuhilnehc-ynos
iuhilnehc-ynos approved these changes Aug 2, 2022
View reviewed changes
Copy link

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fujitatomoya
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Contributor Author

@clalancette CI is unstable, are we having any problems on CI?

@iuhilnehc-ynos
Copy link

@fujitatomoya

I think @clalancette had already fixed it in this PR(ros2/ci#677).

@fujitatomoya
Copy link
Contributor Author

CI retry:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron self-requested a review August 9, 2022 23:24
jacobperron
jacobperron approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable. It makes the behavior more consistent between subscriptions in rclcpp and rclpy.

@jacobperron jacobperron merged commit 20df683 into ros2:rolling Aug 9, 2022
@jacobperron jacobperron mentioned this pull request Aug 9, 2022
Closed
@fujitatomoya
Copy link
Contributor Author

@Mergifyio backport humble galactic foxy

@mergify mergify bot mentioned this pull request Aug 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 10, 2022
@fujitatomoya @mergify
Change decode error mode to replace (#176)
728f861 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)
mergify bot pushed a commit that referenced this pull request Aug 10, 2022
@fujitatomoya @mergify
Change decode error mode to replace (#176)
f8d40c2 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)
@mergify mergify bot mentioned this pull request Aug 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 10, 2022
@fujitatomoya @mergify
Change decode error mode to replace (#176)
2a8e651 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)
@mergify mergify bot mentioned this pull request Aug 10, 2022
Merged
@mergify
Copy link

mergify bot commented Aug 10, 2022

backport humble galactic foxy

✅ Backports have been created

sloretz added a commit that referenced this pull request Aug 22, 2022
@oysstu @fujitatomoya
@jacobperron @sloretz
Allow NaN values to pass floating point bounds check. (#167)
52e099e 
* Invert bounds check in order to permit floating point NaN values

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Allow floating point numbers set to Inf to pass bounds check

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Add float/double NaN/Inf tests

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Increase precision of float32 bounds

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Only perform float64 bounds check on non-compliant IEEE 754 systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Resolve failing nan/inf test by comparing the same types

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Change decode error mode to replace (#176)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* Replace rosidl_cmake imports with rosidl_pycommon (#177)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Delete trailing whitespace

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Split fail case array check tests into two

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

Signed-off-by: Øystein Sture <os@skarvtech.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette pushed a commit that referenced this pull request Oct 18, 2022
@mergify @fujitatomoya
Change decode error mode to replace (#176) (#181)
3788639 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Oct 19, 2022
@mergify @fujitatomoya
Change decode error mode to replace (#176) (#179)
2e99c8b 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Oct 19, 2022
@mergify @fujitatomoya
Change decode error mode to replace (#176) (#180)
010ebc9 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 20df683)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Nov 7, 2022
@oysstu @fujitatomoya
@jacobperron @sloretz @clalancette
Allow NaN values to pass floating point bounds check. (#167)
db6c5b8 
* Invert bounds check in order to permit floating point NaN values

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Allow floating point numbers set to Inf to pass bounds check

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Add float/double NaN/Inf tests

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Increase precision of float32 bounds

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Only perform float64 bounds check on non-compliant IEEE 754 systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Resolve failing nan/inf test by comparing the same types

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Change decode error mode to replace (#176)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* Replace rosidl_cmake imports with rosidl_pycommon (#177)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Delete trailing whitespace

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Split fail case array check tests into two

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

Signed-off-by: Øystein Sture <os@skarvtech.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette added a commit that referenced this pull request Nov 8, 2022
@clalancette @oysstu
@fujitatomoya @jacobperron @sloretz @Crola1702 @lopsided98
Humble: Backport NaN fixes (#188)
c881598 
* Allow NaN values to pass floating point bounds check. (#167)

* Invert bounds check in order to permit floating point NaN values

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Allow floating point numbers set to Inf to pass bounds check

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Add float/double NaN/Inf tests

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Increase precision of float32 bounds

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Only perform float64 bounds check on non-compliant IEEE 754 systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Disable bounds test for float64 on IEEE 754 compatible systems

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Resolve failing nan/inf test by comparing the same types

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Change decode error mode to replace (#176)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* Replace rosidl_cmake imports with rosidl_pycommon (#177)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Delete trailing whitespace

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Split fail case array check tests into two

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

Signed-off-by: Øystein Sture <os@skarvtech.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>

* 👨‍🌾 Fix NaN values bound numpy windows version (#182)

* Replaced equal_nan for numpy<1.19

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Remove stray numpy import (#185)

NumPy was being imported in the template code (not the template output) for
apparently no reason. This was causing problems when cross-compiling, where
NumPy is only available for the target platform.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>

Signed-off-by: Øystein Sture <os@skarvtech.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
Co-authored-by: Øystein Sture <oysstu@users.noreply.github.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com>
Co-authored-by: Ben Wolsieffer <benwolsieffer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fujitatomoya @iuhilnehc-ynos @jacobperron