Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow NaN values to pass floating point bounds check. #167

Merged
merged 13 commits into from
Aug 22, 2022
Merged

Allow NaN values to pass floating point bounds check. #167

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
36cac68
Invert bounds check in order to permit floating point NaN values
oysstu May 19, 2022
b73beef
Allow floating point numbers set to Inf to pass bounds check
oysstu Jul 15, 2022
4abb790
Add float/double NaN/Inf tests
oysstu Jul 16, 2022
26ab69b
Increase precision of float32 bounds
oysstu Jul 18, 2022
490a7fd
Only perform float64 bounds check on non-compliant IEEE 754 systems
oysstu Jul 18, 2022
b966bc0
Disable bounds test for float64 on IEEE 754 compatible systems
oysstu Aug 1, 2022
1af52bd
Disable bounds test for float64 on IEEE 754 compatible systems
oysstu Aug 1, 2022
fb555a2
Resolve failing nan/inf test by comparing the same types
oysstu Aug 1, 2022
20df683
Change decode error mode to replace (#176)
fujitatomoya Aug 9, 2022
5560452
Replace rosidl_cmake imports with rosidl_pycommon (#177)
jacobperron Aug 10, 2022
78fea5b
Merge branch 'oysstu/fix_bounds_check_nan' of github.com:oysstu/rosid…
sloretz Aug 17, 2022
4ff1160
Delete trailing whitespace
sloretz Aug 17, 2022
0431832
Split fail case array check tests into two
sloretz Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rosidl_generator_py/resource/_msg.py.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,14 +506,14 @@ bound = 2**nbits
name = "float"
bound = 3.402823e+38
}@
all(val >= -@(bound) and val <= @(bound) for val in value)), \
not any(val < -@(bound) or val > @(bound) for val in value)), \
oysstu marked this conversation as resolved.
Show resolved Hide resolved
@{assert_msg_suffixes.append('and each float in [%f, %f]' % (-bound, bound))}@
@[ elif type_.typename == "double"]@
@{
name = "double"
bound = 1.7976931348623157e+308
}@
all(val >= -@(bound) and val <= @(bound) for val in value)), \
not any(val < -@(bound) or val > @(bound) for val in value)), \
@{assert_msg_suffixes.append('and each double in [%f, %f]' % (-bound, bound))}@
@[ end if]@
@[ else]@
Expand Down Expand Up @@ -569,7 +569,7 @@ name = "double"
bound = 1.7976931348623157e+308
}@
@[ end if]@
assert value >= -@(bound) and value <= @(bound), \
assert not (value < -@(bound) or value > @(bound)), \
oysstu marked this conversation as resolved.
Show resolved Hide resolved
"The '@(member.name)' field must be a @(name) in [@(-bound), @(bound)]"
@[ end if]@
@[ else]@
Expand Down