Don't override user provided compile definitions (backport #145) #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Don't override user provided compile definitions Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 454a7bc)
There was a problem hiding this comment.
@sloretz @quarkytale if you could merge these suggestions, then I will kick off CI. I think it's best not to change the CXX_STANDARD property for a released distro, instead better to just fix only the issue at hand
rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
emersonknapp
approved these changes
Jun 15, 2023
…faces.cmake Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@google.com>
…nterfaces.cmake Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@google.com>
sloretz
force-pushed
the
mergify/bp/iron/pr-145
branch
from
20fb5cf
to
400c029
Compare
Done, and thanks! |
|
Pulls: #146
|
|
@clalancette @sloretz merge ping! |
clalancette
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #145 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com