-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FindPython3 in typesupport packages #118
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Short windows CI again, this time including ros2/rosidl_typesupport_fastrtps#78: Full CI again, this time including ros2/rosidl_typesupport_fastrtps#78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
I'm surprised the nightly linux didn't break - I can't get builds to succeed for message packages |
Yes, for reasons I don't understand, it seems to be different for different people. It's working fine for me locally, for instance, and it also worked on Linux and macOS on https://ci.ros2.org/view/nightly/. Regardless, the full CI we are running now should show whether it works on all platforms. |
Windows CI has two test failures not in the previous CI job https://ci.ros2.org/view/nightly/job/nightly_win_rel/2022/#showFailuresLink
But that's a lot better than failing to build, so I'll merge these PRs. |
Alternative to ros2/rosidl#615
I think with both ament/ament_cmake#355 and ros2/rosidl#612 being merged yesterday, two sources of packages internally calling
find_package(PythonInterp)
got removed, but their CI's were run at different times. This replaces the implicitPythonInterp
dependency with an explicit finding ofPython3
.