Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FindPython3 in typesupport packages #118

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 12, 2021

Alternative to ros2/rosidl#615

I think with both ament/ament_cmake#355 and ros2/rosidl#612 being merged yesterday, two sources of packages internally calling find_package(PythonInterp) got removed, but their CI's were run at different times. This replaces the implicit PythonInterp dependency with an explicit finding of Python3.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Aug 12, 2021
@sloretz sloretz changed the title Use FindPython3 Use FindPython3 in typesupport packages Aug 12, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Aug 12, 2021

Short Windows CI to get a quick answer (build: --packages-up-to builtin_interfaces test: --packages-select rosidl_typesupport_c rosidl_typesupport_cpp builtin_interfaces) Build Status

Full CI for a complete answer

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Aug 12, 2021

Short windows CI again, this time including ros2/rosidl_typesupport_fastrtps#78: Build Status

Full CI again, this time including ros2/rosidl_typesupport_fastrtps#78

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@emersonknapp
Copy link
Contributor

I'm surprised the nightly linux didn't break - I can't get builds to succeed for message packages

@clalancette
Copy link
Contributor

I'm surprised the nightly linux didn't break - I can't get builds to succeed for message packages

Yes, for reasons I don't understand, it seems to be different for different people. It's working fine for me locally, for instance, and it also worked on Linux and macOS on https://ci.ros2.org/view/nightly/. Regardless, the full CI we are running now should show whether it works on all platforms.

@sloretz
Copy link
Contributor Author

sloretz commented Aug 12, 2021

Windows CI has two test failures not in the previous CI job https://ci.ros2.org/view/nightly/job/nightly_win_rel/2022/#showFailuresLink

projectroot.test_buffer_client_tester.launch.py
test_tf2.TestBufferClient.test_termination

But that's a lot better than failing to build, so I'll merge these PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants