Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport Foxy] Added benchmark test to rosidl_typesupport_c/cpp (#84) #90

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 7, 2020

  • Added benchmark test to rosidl_typesupport_c

Signed-off-by: ahcorde ahcorde@gmail.com

  • Added benchmark test to rosidl_typesupport_cpp

Signed-off-by: ahcorde ahcorde@gmail.com

  • reset heap counters

Signed-off-by: ahcorde ahcorde@gmail.com

  • Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F

Signed-off-by: ahcorde ahcorde@gmail.com

  • Fixed test

Signed-off-by: ahcorde ahcorde@gmail.com

* Added benchmark test to rosidl_typesupport_c

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added benchmark test to rosidl_typesupport_cpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* reset heap counters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from brawner October 7, 2020 10:18
@ahcorde ahcorde self-assigned this Oct 7, 2020
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 7, 2020

Compiling up-to rosidl_typesupport_c and rosidl_typesupport_cpp with -DAMENT_RUN_PERFORMANCE_TESTS=ON: and testing rosidl_typesupport_c and rosidl_typesupport_cpp

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde force-pushed the ahcorde/foxy/benchmark branch 2 times, most recently from deacbbf to 2a53c3d Compare October 7, 2020 12:16
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 8, 2020

The osrf_testing_tools_cpp memory tools aren't available for Windows or aarch64. Since the performance tests aren't enabled by default, merging this PR won't cause the CMake warning on regular builds. In practice, we have no plans to run these benchmarks on any platform other than Linux x86_64 anyway.

@ahcorde ahcorde merged commit 1e8a62b into foxy Oct 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/foxy/benchmark branch October 8, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants