Add linters and use ament_lint_auto #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still left TODOs for enabling ament_copyright linter once that is able to handle the copyright notices in RViz. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Make rviz_rendering package.xml use same indentation amount as other RViz packages. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
mjeronimo
reviewed
Oct 8, 2020
mjeronimo
approved these changes
Oct 8, 2020
|
Since this is just a small change to the linters (and they should be run as part of the Rpr CI), I'm going to skip testing on other platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still left TODOs for enabling ament_copyright linter once that is able to handle the copyright notices in RViz.