Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include order #858

Merged
merged 1 commit into from May 5, 2022
Merged

Fix include order #858

merged 1 commit into from May 5, 2022

Conversation

jacobperron
Copy link
Member

Related to ament/ament_lint#374

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. If we are considering hh files to be C++ now, cpplint is going to be cranky about the ordering.

This looks reasonable to me with green CI.

@jacobperron
Copy link
Member Author

CI is green: ament/ament_lint#374 (comment)

@jacobperron jacobperron merged commit 7b4ba85 into ros2 May 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/consider_hh_as_cpp_header branch May 5, 2022 22:35
jacobperron added a commit that referenced this pull request May 5, 2022
Related to ament/ament_lint#374

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request May 9, 2022
Related to ament/ament_lint#374

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants