Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 20min ogre download timeout #323

Merged
merged 1 commit into from
Jun 27, 2018
Merged

add 20min ogre download timeout #323

merged 1 commit into from
Jun 27, 2018

Conversation

mikaelarguedas
Copy link
Member

Without timeout if cmake hangs during the download the jobs will never finish: e.g. ros2/build_farmer#77 (comment)

This 20min timeout requires a download speed of ~100kb/s.
I can make it higher if we think it's too hard of a requirement

@mikaelarguedas mikaelarguedas self-assigned this Jun 27, 2018
@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jun 27, 2018
@mikaelarguedas
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas merged commit 978d00c into ros2 Jun 27, 2018
@mikaelarguedas mikaelarguedas deleted the reintroduce_ogre_download_timeout branch June 27, 2018 23:57
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @wjwwood