Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashing backport] Remove uncessary call to render scene (#490) #515

Merged
merged 1 commit into from
Mar 11, 2020
Merged

[dashing backport] Remove uncessary call to render scene (#490) #515

merged 1 commit into from
Mar 11, 2020

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Mar 5, 2020 •
edited
Loading

Backport #490 to Dashing

@jacobperron
Remove uncessary call to render scene (#490)
7f13001 
* Remove uncessary call to render scene

Fixes #486.

At least the call seems unncessary. I haven't noticed any changes in selection render behavior
with or without the change. But, making the call causes an assertion to fail within Ogre when
a selection tool is moused-over an image display (see #486 for details).

The hack was originally added in

ros-visualization/rviz@7feb02d

but it's not clear if the original buggy behavior still exists without it. There's been a lot
of refactoring since then. I've played around with selecting things and haven't noticed any
flickering or discoloration after removing the hack.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix warning about unused parameter

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron changed the title Remove uncessary call to render scene (#490) [dashing backport] Remove uncessary call to render scene (#490) Mar 5, 2020
@jacobperron jacobperron self-assigned this Mar 5, 2020
@jacobperron jacobperron added this to Needs Release in Dashing Patch Release 6 Mar 5, 2020
@nuclearsandwich
Copy link
Member

The builds are coming back "failed" due to an issue with the upgraded XUnit plugin and the XML generated by some of our tests. I've pasted the actual colcon test-result summary below each build.

  • Linux Build Status
    Summary: 2283 tests, 0 errors, 0 failures, 22 skipped

  • Linux-aarch64 Build Status
    Summary: 2283 tests, 0 errors, 0 failures, 22 skipped

  • macOS Build Status
    Summary: 2283 tests, 0 errors, 0 failures, 22 skipped

  • Windows Build Status
    Summary: 2031 tests, 0 errors, 0 failures, 62 skipped

@jacobperron jacobperron merged commit ce16e88 into dashing Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/dashing_backport_490 branch March 11, 2020 17:45
@nuclearsandwich nuclearsandwich moved this from Needs Release to Released in Dashing Patch Release 6 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
No open projects
Dashing Patch Release 6
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @nuclearsandwich