Remove uncessary call to render scene #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #486. At least the call seems unncessary. I haven't noticed any changes in selection render behavior with or without the change. But, making the call causes an assertion to fail within Ogre when a selection tool is moused-over an image display (see #486 for details). The hack was originally added in ros-visualization/rviz@7feb02d but it's not clear if the original buggy behavior still exists without it. There's been a lot of refactoring since then. I've played around with selecting things and haven't noticed any flickering or discoloration after removing the hack. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
approved these changes
Jan 29, 2020
|
jacobperron
added a commit
that referenced
this pull request
Mar 5, 2020
* Remove uncessary call to render scene Fixes #486. At least the call seems unncessary. I haven't noticed any changes in selection render behavior with or without the change. But, making the call causes an assertion to fail within Ogre when a selection tool is moused-over an image display (see #486 for details). The hack was originally added in ros-visualization/rviz@7feb02d but it's not clear if the original buggy behavior still exists without it. There's been a lot of refactoring since then. I've played around with selecting things and haven't noticed any flickering or discoloration after removing the hack. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix warning about unused parameter Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Mar 5, 2020
* Remove uncessary call to render scene Fixes #486. At least the call seems unncessary. I haven't noticed any changes in selection render behavior with or without the change. But, making the call causes an assertion to fail within Ogre when a selection tool is moused-over an image display (see #486 for details). The hack was originally added in ros-visualization/rviz@7feb02d but it's not clear if the original buggy behavior still exists without it. There's been a lot of refactoring since then. I've played around with selecting things and haven't noticed any flickering or discoloration after removing the hack. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix warning about unused parameter Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Mar 5, 2020
jacobperron
added a commit
that referenced
this pull request
Mar 11, 2020
* Remove uncessary call to render scene Fixes #486. At least the call seems unncessary. I haven't noticed any changes in selection render behavior with or without the change. But, making the call causes an assertion to fail within Ogre when a selection tool is moused-over an image display (see #486 for details). The hack was originally added in ros-visualization/rviz@7feb02d but it's not clear if the original buggy behavior still exists without it. There's been a lot of refactoring since then. I've played around with selecting things and haven't noticed any flickering or discoloration after removing the hack. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix warning about unused parameter Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Mar 31, 2020
* Remove uncessary call to render scene Fixes #486. At least the call seems unncessary. I haven't noticed any changes in selection render behavior with or without the change. But, making the call causes an assertion to fail within Ogre when a selection tool is moused-over an image display (see #486 for details). The hack was originally added in ros-visualization/rviz@7feb02d but it's not clear if the original buggy behavior still exists without it. There's been a lot of refactoring since then. I've played around with selecting things and haven't noticed any flickering or discoloration after removing the hack. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix warning about unused parameter Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486.
At least the call seems unncessary. I haven't noticed any changes in selection render behavior
with or without the change. But, making the call causes an assertion to fail within Ogre when
a selection tool is moused-over an image display (see #486 for details).
The hack was originally added in
ros-visualization/rviz@7feb02d
but it's not clear if the original buggy behavior still exists without it. There's been a lot
of refactoring since then. I've played around with selecting things and haven't noticed any
flickering or discoloration after removing the hack.