Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eloquent] Use RViz node clock in tools. #520

Closed
wants to merge 1 commit into from

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 18, 2020

This pull request is an equivalent of #519, but ABI-compatible so it can be backported.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Mar 19, 2020

@wjwwood any other thing you'd want me to do or add before merging?

@mjcarroll since you were (are?) ROS boss for Eloquent, any thoughts?

@mjcarroll
Copy link
Member

LGTM, can you just add a note about it just so that I'll remember to put it in the Patch Release announcement?: ros2/ros2#859

@wjwwood
Copy link
Member

wjwwood commented Mar 19, 2020

You should run Eloquent CI, but other than that no, it's fine to merge.

@hidmic
Copy link
Contributor Author

hidmic commented Mar 19, 2020

Eloquent CI up to rviz_default_plugins:

  • Linux Build Status (canary build)
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Copy link
Member

@hidmic Based on CI for my other backports (#579 (comment)), I think the cmake/compiler warnings are expected. I don't see the same test failure on Windows though; it seems unrelated to this change, maybe it's a flake and worth re-running 🤷‍♂️

@hidmic
Copy link
Contributor Author

hidmic commented Jul 30, 2020

Nope, the test failure is still there. I'll have to dig in.

@hidmic
Copy link
Contributor Author

hidmic commented Nov 10, 2020

Eloquent goes EOL this month. I don't think I'll have time to circle back to this. This is fixed in newer versions, so I'll close this now.

@hidmic hidmic closed this Nov 10, 2020
@mjcarroll mjcarroll moved this from Needs Release to Released in Eloquent Patch Release 2 Dec 4, 2020
@mjcarroll mjcarroll removed this from Released in Eloquent Patch Release 2 Dec 4, 2020
@clalancette clalancette deleted the hidmic/eloquent/use-node-clock-in-tools branch June 1, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants