Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove YAML_CPP_DLL define #831

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove YAML_CPP_DLL define #831

merged 1 commit into from
Oct 4, 2022

Conversation

Ace314159
Copy link
Contributor

Since ros2/yaml_cpp_vendor#10 is fixed, the explicit YAML_CPP_DLL define is no longer needed and needs to be removed to prevent the macro redefinition warnings.

This should be backported to foxy and galactic.

@Ace314159 Ace314159 mentioned this pull request Feb 19, 2022
Closed
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 8 via automation Feb 22, 2022
@jacobperron jacobperron added this to Needs backport in Galactic Patch Release 2 Feb 22, 2022
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 8 Feb 22, 2022
@jacobperron
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron self-assigned this Feb 22, 2022
@audrow audrow changed the base branch from ros2 to rolling June 28, 2022 14:24
@jacobperron jacobperron moved this from Needs backport to Proposed in Foxy Patch Release 8 Jul 22, 2022
@jacobperron
Copy link
Member

Triggering Windows CI to see where we stand: Build Status

This was referenced Sep 19, 2022
Closed
Merged
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 8 Sep 20, 2022
@jacobperron jacobperron added this to TODO in Humble Patch Release 1 via automation Sep 20, 2022
@jacobperron jacobperron moved this from TODO to Needs backport in Humble Patch Release 1 Sep 20, 2022
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 8 Sep 23, 2022
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 9 via automation Sep 23, 2022
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 9 Sep 23, 2022
@jacobperron jacobperron moved this from Needs backport to In progress in Foxy Patch Release 9 Sep 23, 2022
@jacobperron
Copy link
Member

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 8fd7eab into ros2:rolling Oct 4, 2022
@quarkytale quarkytale removed this from In progress in Foxy Patch Release 9 Oct 13, 2022
@quarkytale quarkytale added this to In progress in Foxy Patch Release 10 Oct 13, 2022
@audrow audrow moved this from Needs backport to Done in Humble Patch Release 1 Nov 23, 2022
@quarkytale quarkytale removed this from In progress in Foxy Patch Release 10 Mar 16, 2023
@quarkytale quarkytale added this to Needs backport in Foxy Patch Release 11 Mar 16, 2023
@quarkytale quarkytale removed this from Needs backport in Foxy Patch Release 11 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jacobperron jacobperron

Labels
None yet
Projects
No open projects
Galactic Patch Release 2
Needs backport
Humble Patch Release 1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ace314159 @jacobperron