Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rolling] Export YAML_CPP_DLL define on Windows (#30) #38

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

jacobperron
Copy link
Member

Forward port #30 to Rolling.

This should fix #10

Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
@jacobperron
Copy link
Member Author

Requires the following changes to avoid build warnings:

@jacobperron
Copy link
Member Author

CI with connected PRs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a suggestion for a comment, just to capture some of the investigation we did yesterday. I'm still approving since it is just a comment. No need to rerun CI with this change; a clean Rpr job is enough (and green CI on Windows, obviously).

yaml_cpp_vendor-extras.cmake.in Outdated Show resolved Hide resolved
jacobperron and others added 2 commits September 28, 2022 15:19
Signed-off-by: Jacob Perron <jacob@openrobotics.org>

Co-authored-by: Akash <Ace314159@users.noreply.github.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

jacobperron commented Sep 28, 2022

Windows Build Status

@jacobperron jacobperron merged commit b813bbe into rolling Oct 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/rolling_forward_port_30 branch October 4, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] It is nice YAML_CPP_DLL is exported by default.
3 participants