Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[galactic] Export YAML_CPP_DLL define on Windows #31

Closed
wants to merge 2 commits into from
Closed

[galactic] Export YAML_CPP_DLL define on Windows #31

wants to merge 2 commits into from

Conversation

Ace314159
Copy link
Contributor

Fixes #10

@Ace314159
Export YAML_CPP_DLL define on Windows
f536821 
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
@Ace314159 Ace314159 mentioned this pull request Feb 3, 2022
Merged
@clalancette clalancette mentioned this pull request Feb 3, 2022
Closed
jacobperron
jacobperron approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Windows: Build Status

@jacobperron jacobperron added this to Needs release in Galactic Patch Release 2 Feb 16, 2022
@clalancette
Copy link
Contributor

While this is the right thing to do, it also means that we need to "undo" all of the places where we hard-coded YAML_CPP_DLL before. That's why the Windows CI build is yellow.

@Ace314159
Copy link
Contributor Author

Ace314159 commented Feb 19, 2022 •
edited
Loading

I can make PRs to do that.

I have made:

@gbiggs
Copy link
Member

gbiggs commented Feb 21, 2022

Holding this PR until the related PRs are merged so we can get green Windows CI.

@jacobperron jacobperron mentioned this pull request Feb 22, 2022
Merged
@Ace314159 Ace314159 mentioned this pull request Feb 25, 2022
Merged
@clalancette clalancette added the more-information-needed Further information is required label Apr 7, 2022
@jacobperron jacobperron mentioned this pull request Sep 12, 2022
Closed
@Ace314159
Fix target
b86bda4 
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
@gbiggs
Copy link
Member

gbiggs commented Oct 4, 2022

Let's try some CI!

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@quarkytale
Copy link

Closing this out since Galactic is EOL

@quarkytale quarkytale closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
No open projects
Galactic Patch Release 2
Needs release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ace314159 @clalancette @gbiggs @quarkytale @jacobperron