Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: reorganize permission API #191

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

kyrofa
Copy link
Member

@kyrofa kyrofa commented Apr 7, 2020

This PR continues the reorganization of #188 by extracting the permission API into its own module.

Note that this introduces no behavioral changes, it's just moving code around.

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
ruffsl
ruffsl previously approved these changes Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #191 into master will increase coverage by 0.23%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   54.92%   55.15%   +0.23%     
==========================================
  Files          15       16       +1     
  Lines         579      582       +3     
  Branches       52       52              
==========================================
+ Hits          318      321       +3     
  Misses        247      247              
  Partials       14       14              
Flag Coverage Δ
#unittests 55.15% <59.09%> (+0.23%) ⬆️
Impacted Files Coverage Δ
sros2/sros2/verb/create_permission.py 0.00% <0.00%> (ø)
sros2/sros2/api/_permission.py 61.53% <61.53%> (ø)
sros2/sros2/api/__init__.py 65.00% <66.66%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d471919...bea4e4e. Read the comment docs.

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyrofa kyrofa merged commit 98d856a into ros2:master Apr 7, 2020
@kyrofa kyrofa deleted the feature/api-clean-permission branch April 7, 2020 22:47
@kyrofa kyrofa mentioned this pull request Apr 8, 2020
3 tasks
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants