problem with ros2cli

[wjwwood]

I just setup the latest ros2.repos on my Windows desktop at home and when I run an unrelated ros2cli command I get an error from the create_permission verb in this repository:

C:\Windows\System32>ros2 topic list
Traceback (most recent call last):
  File "C:\dev\ros2\install\bin\ros2-script.py", line 11, in <module>
    load_entry_point('ros2cli==0.0.0', 'console_scripts', 'ros2')()
  File "C:\dev\ros2\install\Lib\site-packages\ros2cli\cli.py", line 44, in main
    hide_extensions=['extension_points', 'extensions'])
  File "C:\dev\ros2\install\Lib\site-packages\ros2cli\command\__init__.py", line 111, in add_subparsers
    command_parser, '{cli_name} {name}'.format_map(locals()))
  File "C:\dev\ros2\install\Lib\site-packages\sros2\command\security.py", line 26, in add_arguments
    add_subparsers(parser, cli_name, '_verb', verb_extensions)
  File "C:\dev\ros2\install\Lib\site-packages\ros2cli\command\__init__.py", line 111, in add_subparsers
    command_parser, '{cli_name} {name}'.format_map(locals()))
  File "C:\dev\ros2\install\Lib\site-packages\sros2\verb\create_permission.py", line 40, in add_arguments
    allowednames=('yaml'), directories=False)
TypeError: FilesCompleter() got an unexpected keyword argument 'allowednames'

[codebot]

I got that too, but it went away when I installed python3-argcomplete via apt (or something similarly named, can't remember exactly).

[mikaelarguedas]

hmmm, I haven't tested this on Windows. Very likely related to #4 (comment). Does installing argcomplete through pip solve it for you as well ? (lyou'll likely need at least version 0.8.5)

[wjwwood]

I think argcomplete is supposed to be optional, so even if it would fix it, I think this needs to still work or fail more gracefully. I'll try it asap.

@dirk-thomas didn't you end up making argcomplete optional?

[wjwwood]

That does fix the issue, but I still think it should fixed so it is optional.