refer to new DDS-Security 1.1 XSDs now that they're available #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in review
dirk-thomas
reviewed
Jul 13, 2018
| @@ -145,17 +145,12 @@ def create_governance_file(path, domain_id): | |||
| f.write("""\ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <dds xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://www.omg.org/spec/DDS-SECURITY/20160303/omg_shared_ca_governance.xsd"> | |||
| xsi:noNamespaceSchemaLocation="http://www.omg.org/spec/DDS-SECURITY/20170901/omg_shared_ca_governance.xsd"> | |||
There was a problem hiding this comment.
Why not use https here since the URL is redirected to that one anyway?
Same below.
There was a problem hiding this comment.
Because the examples in the spec and the examples on OMG website use http.
As there is currently no downside in keeping the http link I figured I'd keep it consistent with the examples.
And who knows, maybe OMG plan ons providing an http hosting and not a redirect in the future ? 🤞
dirk-thomas
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the XSDs for DDS_Security 1.1 are out. we can refer to them (our generated files were already using tags from 1.1).
While our "wildcard" generated file comply with the new schema:
The ones containing explicit access control rules still don't as described in #49