Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_artifacts verb #107

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Apr 4, 2019

Python implementation of #82

Includes commits from #106 until it is merged.
Only third commit is relevant 5136c7d.

How to test it:

Generate the artifacts for /talker2 and all the identities in sample_policy.xml:

mkdir -p /tmp/sros2_demo && cd /tmp/sros2_demo
svn checkout https://github.com/ros2/sros2/trunk/sros2/test/policies
ros2 security generate_artifacts -k demo_keys -n /talker2 -p /tmp/sros2_demo/policies/sample_policy.xml

Run:

export ROS_SECURITY_ENABLE=true
export ROS_SECURITY_STRATEGY=Enforce
export ROS_SECURITY_ROOT_DIRECTORY=/tmp/sros2_demo/demo_keys
ros2 run demo_nodes_py listener &
ros2 run demo_nodes_cpp talker

killing the talker and running the following should also work:

ros2 run demo_nodes_cpp talker __node:=talker2

this should fail:

ros2 run demo_nodes_cpp talker __node:=talker3

The sros2 tutorial should still work as well

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 4, 2019
@mjcarroll
Copy link
Member

Tested locally 👍, but haven't reviewed the code yet.

@mjcarroll
Copy link
Member

Will also cover #106:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas
Copy link
Member Author

thanks @mjcarroll for the express reviews! 💯 🙇‍♂️

If you merge this and close #106, can you please "Create a merge commit" rather than "Squash and merge" to keep the commits separated?

Thanks!

@mjcarroll
Copy link
Member

Helps that you were at the top of the inbox this morning. Will do after @ross-desmond gets a chance to comment on #106 (but I'm not anticipating any issues)

@mjcarroll mjcarroll merged commit a56d851 into ros2:master Apr 4, 2019
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Apr 4, 2019
@mikaelarguedas mikaelarguedas deleted the autogenerate_artifacts branch April 4, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants