Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sros2_cmake use generate_artifacts command #108

Merged
merged 1 commit into from
Apr 17, 2019
Merged

make sros2_cmake use generate_artifacts command #108

merged 1 commit into from
Apr 17, 2019

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Apr 4, 2019 •
edited
Loading

Depends on #107

Fixes #82

Gets rid of the ros2_create_keystore macro
Single ros2 security invocation speeds up the generation (~3 times faster for 6 nodes)

@mikaelarguedas
make sros2_cmake use generate_artifacts command
c968397 
this allows to get rid of the ros2_create_keystore macro
call a single ros2 security command, the single python invocation
results in significant speed improvement

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 4, 2019
@mikaelarguedas mikaelarguedas mentioned this pull request Apr 4, 2019
Closed
@mjcarroll mjcarroll merged commit 7420998 into ros2:master Apr 17, 2019
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Apr 17, 2019
ryanewel pushed a commit to aws-ros-dev/sros2 that referenced this pull request Jun 12, 2019
@mikaelarguedas @ryanewel
make sros2_cmake use generate_artifacts command (ros2#108)
12523d1 
this allows to get rid of the ros2_create_keystore macro
call a single ros2 security command, the single python invocation
results in significant speed improvement

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas deleted the cmake_use_generate_artifacts branch August 1, 2019 21:23
@mikaelarguedas mikaelarguedas mentioned this pull request Mar 26, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easy way to generate artifacts for all nodes in policy file
2 participants
@mikaelarguedas @mjcarroll