-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dockerfile to use beta2 binaries #14
Conversation
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Is there a will to keep a Dockerfile building the code from source as an example ? I know that several users mentioned wanting to have a dockerfile for ROS2 development / testing including @chapulina yesterday. |
Currently we don't maintain any Dockerfiles for ROS 2. Instead we provide from-source instructions only. To minimize the effort to maintain both and keeping them in sync I would favor only supporting one. That can be the from source instructions (so users have to copy-n-paste the lines into a Dockerfile) or we could provide a Dockerfile which contains plenty of comments (which then can serve as the from-source instructions). |
👍 I like the idea and don't feel strongly about one rather than the other |
The second option even has the benefit that we could automate the build which will ensure that our instructions work as intended. |
Agreed. |
No description provided.