-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for node discovery in test_generate_policy. #262
Conversation
Only when daemon is in use (if not, CLI will use a different node). Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@ros-pull-request-builder retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better to me, thanks. And CI seems to be happy with it as well.
Cool, thanks for the reviews! Does anybody have the bits to merge now? 😅 |
@SidFaber If you get a chance, can you review/merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@kyrofa or @mikaelarguedas can you merge? |
How was it tested that this addresses the issue ? Looking at CI for this PR, it's not repeating any test so I'm not sure we can use that as reference to determine it reduces flakiness of a given test. Comparing nightly CI referenced in the original issue: So maybe this PR did not have an effect ? |
Replacement for #260. Only wait when daemon is in use (if not, CLI will use a different node).
CI up to
sros2
: