Adjusted spin_some test due to new behavior #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously would constantly trigger based on a 0ms delay timer; now only evaluates a single timer once per spin_some call. Test now adds multiple timers with a short delay to simulate performing work. Relies on behavior change from ros2/rclcpp#844, addressing ros2/rclcpp#471 Distribution Statement A; OPSEC #2893 Signed-off-by: Roger Strain <rstrain@swri.org>
roger-strain
force-pushed
the
spin_some_update_rclcpp_844
branch
from
ba87932
to
e8e273d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously would constantly trigger based on a 0ms delay timer;
now only evaluates a single timer once per spin_some call. Test
now adds multiple timers with a short delay to simulate performing
work.
Relies on behavior change from ros2/rclcpp#844, addressing
ros2/rclcpp#471
Distribution Statement A; OPSEC #2893
Signed-off-by: Roger Strain rstrain@swri.org