Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test which uses the create_subscription with queue size api #56

Merged
merged 2 commits into from
Oct 14, 2015

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Oct 14, 2015

Connects to ros2/design#56.

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Oct 14, 2015
@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 14, 2015
@dirk-thomas
Copy link
Member

Does this test have to replicate the whole testing with spin etc. or is it sufficient to only check the signature to create a subscription with a queue size?

@wjwwood
Copy link
Member Author

wjwwood commented Oct 14, 2015

Well, I figure it was worth making sure a subscription created with this API would result in a functioning subscription, but I can slim the test down further if you don't think that's important.

@dirk-thomas
Copy link
Member

Related to my other comment (ros2/rclcpp#128 (comment)) I would think testing the functionality of the core functionality is enough. For the syntactic sugar API a simple test checking that a specific signature works would be enough.

@wjwwood
Copy link
Member Author

wjwwood commented Oct 14, 2015

Ok I simplified the test to just creating a subscription. The tests passed locally, so I won't run another CI.

@esteve
Copy link
Member

esteve commented Oct 14, 2015

+1

@dirk-thomas
Copy link
Member

lgtm

wjwwood added a commit that referenced this pull request Oct 14, 2015
add a test which uses the create_subscription with queue size api
@wjwwood wjwwood merged commit 96180a7 into master Oct 14, 2015
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Oct 14, 2015
@wjwwood wjwwood deleted the create_subscription_with_queue_size branch October 14, 2015 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants