-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BoundedPlainSequences messages #14
Conversation
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Circling back, sorry for the delay!
msg/BoundedSequencesNoStrings.msg
Outdated
@@ -0,0 +1,32 @@ | |||
# Bounded sequences of different types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiguelCompany if the core idea behind adding messages is to have bounded sequence of plain data types, consider making that explicit in the name e.g. BoundedPlainSequences
, BoundedPODSequences
or any meaningful name you like.
msg/UnboundedSequencesNoStrings.msg
Outdated
@@ -0,0 +1,32 @@ | |||
# Unbounded sequences of different types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiguelCompany if you have no use case for this message type, please don't add it.
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Alright, finally green. Going in! |
This is Steve your friendly build farmer here checking in. I don't know if it was this or ros2/rcl_interfaces#123, but the last nightly build shows quite a few failures in the test_communication package related to I'm not sure if this PR's CI builds included the |
@scpeters @hidmic It seems I see two different issues here:
|
Adding two message definitions with sequences of POD types