Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BoundedPlainSequences to test_msgs #123

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Added BoundedPlainSequences to test_msgs #123

merged 2 commits into from
Aug 4, 2021

Conversation

MiguelCompany
Copy link
Contributor

@MiguelCompany MiguelCompany commented Jun 8, 2021 •
edited
Loading

Adding one message definition with bounded sequences of POD types

Depends on ros2/test_interface_files#14

@MiguelCompany
Added BoundedSequencesNoStrings and UnboundedSequencesNoStrings.
9211cef 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title Added BoundedSequencesNoStrings and UnboundedSequencesNoStrings Added BoundedSequencesNoStrings and UnboundedSequencesNoStrings to test_msgs Jun 8, 2021
@MiguelCompany MiguelCompany mentioned this pull request Jun 8, 2021
Merged
hidmic
hidmic reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment here follows ros2/test_interface_files#14 (comment). Drop the message types you don't need.

@MiguelCompany
Update message_fixtures.py
99c047c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
hidmic
hidmic approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiguelCompany don't forget to update the PR title!

@MiguelCompany MiguelCompany changed the title Added BoundedSequencesNoStrings and UnboundedSequencesNoStrings to test_msgs Added BoundedPlainSequences to test_msgs Jun 16, 2021
@MiguelCompany
Copy link
Contributor Author

@MiguelCompany don't forget to update the PR title!

@hidmic Done. I've also updated the description.

@hidmic
Copy link
Contributor

hidmic commented Jun 16, 2021 •
edited
Loading

CI up to rmw_fastrtps_cpp, rmw_fastrtps_dynamic_cpp, rcl_interfaces and test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette added the more-information-needed Further information is required label Jul 1, 2021
@hidmic
Copy link
Contributor

hidmic commented Jul 30, 2021

MacOS CI, one more time:

  • macOS Build Status

@hidmic
Copy link
Contributor

hidmic commented Aug 4, 2021

CI again as it's been a while:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic removed the more-information-needed Further information is required label Aug 4, 2021
@hidmic hidmic merged commit 5e5ae6f into ros2:master Aug 4, 2021
@MiguelCompany MiguelCompany deleted the sequences-no-strings branch August 5, 2021 06:58
@scpeters scpeters mentioned this pull request Aug 5, 2021
Merged
@sloretz sloretz mentioned this pull request Aug 5, 2021
Merged
@sloretz sloretz mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MiguelCompany @hidmic @clalancette