fix sized delete warning with c++14 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wjwwood
added
in review
codebot
approved these changes
Dec 18, 2016
There was a problem hiding this comment.
lgtm. If you wanted to save a few lines of code, you could just call the unsized delete operator from the sized one, to avoid having to repeat the logic that checks is_running, like here:
ros2/realtime_support@ea5dd3d
but it's not a big deal.
|
+1 with @codebot comment addressed. |
|
It will probably be tomorrow before I have access to a computer, if you guys want to change it and then merge, +1. |
|
I'll try to change it now. Hopefully I won't destroy everything in the process. |
|
Should be OK now. Just forwards the sized delete call through to the unsized one. At least it compiles 😄 |
dirk-thomas
approved these changes
Dec 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13 (comment)