Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a Doxyfile to predefine macros. #28

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

clalancette
Copy link

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This should fix the Rdoc job at https://build.ros2.org/view/Rdoc/job/Rdoc__urdf__ubuntu_focal_amd64/

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for one small nit

urdf/Doxyfile Outdated Show resolved Hide resolved
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
@clalancette
Copy link
Author

Applied the fix as you suggested. Since this is "just" a Doxyfile change, I'm just going to rely on the Rpr job for CI here. Thanks for the review, merging.

@clalancette clalancette merged commit 846c25c into ros2 Nov 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-docs branch November 4, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants