Deprecate methods that require tinyxml #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ros2#11 to land in Foxy+1
|
|
@rotu restarted CI testing only urdf and the packages above. We're a bit tight on CI capacity right now; so please make sure to use build and test args to limit the time a job takes when possible.
|
CI run shows deprecation warnings, which are addressed by pending PRs: ros2/kdl_parser#7 and ros2/rviz#531 |
|
@sloretz What's the status on this? |
clalancette
approved these changes
May 14, 2020
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
May 19, 2020
|
For future reference, CI for this was in ros2/rviz#531 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11 to land in Foxy+1