Support yaml-cpp >= 0.8.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
1 task
clalancette
approved these changes
Feb 12, 2024
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since yaml-cpp 0.8.0, the imported target of yaml-cpp is called
yaml-cpp::yaml-cpp, notyaml-cpp.To handle this, in this PR I modified the logic that sets
yaml_cpp_vendor_TARGETSto set it toyaml-cpp::yaml-cppif it exists. Furthermore, I also use the presence ofyaml-cpp::yaml-cppas a proxy to detect if yaml-cpp >= 0.8.0 is used, and avoid the manual setting ofYAML_CPP_DLLas it is not needed anymore.If
yaml-cpp::yaml-cppis not present (i.e. yaml-cpp <= 0.7.0), the logic remains exactly the one before this PR.Related downstream comment: RoboStack/ros-humble#136 (comment) .